Skip to content

Added Bengali Language Support to the editor and Some terms are converted into Korean #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 30, 2023
Merged

Added Bengali Language Support to the editor and Some terms are converted into Korean #2618

merged 15 commits into from
Nov 30, 2023

Conversation

swrno
Copy link
Contributor

@swrno swrno commented Nov 17, 2023

Fixes #2616
Changes:

Screenshot (23)
Screenshot (24)
Screenshot (25)

As a native bengali speaker, I have personally checked and verified all the words and sentences are correct.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

raclim
raclim requested changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this! I personally don't speak Bengali, but I think this looks great so far!

I would remove the translation changes to the following files though to keep it consistent to the purpose of this pull request, which is adding Bengali translations:

  • translations/locales/fr-CA/translations.json
  • translations/locales/hi/translations.json
  • translations/locales/it/translations.json
  • translations/locales/ja/translations.json
  • translations/locales/ko/translations.json
  • translations/locales/pt-BR/translations.json
  • translations/locales/sv/translations.json
  • translations/locales/tr/translations.json
  • translations/locales/uk-UA/translations.json

@swrno
Copy link
Contributor Author

swrno commented Nov 17, 2023 •
edited
Loading

Thanks so much for working on this! I personally don't speak Bengali, but I think this looks great so far!

I would remove the translation changes to the following files though to keep it consistent to the purpose of this pull request, which is adding Bengali translations:

  • translations/locales/fr-CA/translations.json
  • translations/locales/hi/translations.json
  • translations/locales/it/translations.json
  • translations/locales/ja/translations.json
  • translations/locales/ko/translations.json
  • translations/locales/pt-BR/translations.json
  • translations/locales/sv/translations.json
  • translations/locales/tr/translations.json
  • translations/locales/uk-UA/translations.json

Great! Thanks for your guidance and support.

@lindapaiste
Copy link
Collaborator

@raclim @Swarnendu0123 If we merge the other PR first then those changes won't show up as "Files changed" here.

@swrno
Copy link
Contributor Author

swrno commented Nov 18, 2023 •
edited
Loading

Yeah! That's also a good idea. On the confirmation of @raclim , let's first merge those 2 PRs and then this PR.

swrno added 6 commits November 19, 2023 01:58
@swrno
Merge branch 'develop' into bengali-language
9e20679
@swrno
Delete translations/locales/fr-CA/translations.json
95f1187
@swrno
fr-CA added
304346a
@swrno
Update translations.json
126a94d
@swrno
translations/locales/fr-CA/translations.json
7661462 
translations/locales/hi/translations.json
translations/locales/it/translations.json
translations/locales/ja/translations.json
translations/locales/ko/translations.json
translations/locales/pt-BR/translations.json
translations/locales/sv/translations.json
translations/locales/tr/translations.json
translations/locales/uk-UA/translations.json files modified
@swrno
Merge branch 'bengali-language' of https://github.com/Swarnendu0123/p…
5644328 
…5.js-web-editor into bengali-language
@swrno swrno changed the title Added Bengali Language Support to the editor Added Bengali Language Support to the editor and Some terms are converted into Korean Nov 18, 2023
@swrno
Copy link
Contributor Author

swrno commented Nov 18, 2023 •
edited
Loading

Thanks so much for working on this! I personally don't speak Bengali, but I think this looks great so far!

I would remove the translation changes to the following files though to keep it consistent to the purpose of this pull request, which is adding Bengali translations:

  • translations/locales/fr-CA/translations.json
  • translations/locales/hi/translations.json
  • translations/locales/it/translations.json
  • translations/locales/ja/translations.json
  • translations/locales/ko/translations.json
  • translations/locales/pt-BR/translations.json
  • translations/locales/sv/translations.json
  • translations/locales/tr/translations.json
  • translations/locales/uk-UA/translations.json

Hey @raclim I have removed all your mentioned files now its ready for merging. I have not removed Korean language file because some terms are added which makes the editor completely into Korean, if Korean is selected as a language.

@swrno swrno mentioned this pull request Nov 20, 2023
Closed
@raclim raclim added this to the MINOR Release for 2.10.0 milestone Nov 20, 2023
@swrno swrno requested a review from raclim November 24, 2023 20:10
raclim
raclim approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for getting to this a bit late and thanks for removing all of the files!

I don't feel 100% confident about keeping the Korean translations, but I think they could be okay for now. Thanks again for your work!

@raclim raclim merged commit 35dc27f into processing:develop Nov 30, 2023
@swrno swrno deleted the bengali-language branch November 30, 2023 19:45
@swrno swrno mentioned this pull request Dec 28, 2023
Open
@swrno swrno mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

PATCH Release for 2.10.1

Development

Successfully merging this pull request may close these issues.

Add Bengali Language Support to the Full Editor

3 participants

@swrno @lindapaiste @raclim