Skip to content

Conversation

swrno
Copy link
Contributor

@swrno swrno commented Dec 8, 2023

Fixes #2692, Ref #2609

Changes:
Trems Web Editor, Home, Twitter, Instagram, Discord changed in About Block

Screenshot (34)
Screenshot (37)
Screenshot (38)

About Block is now completely in all available languages:
Bengali
Spanish (Latin America)
French
German
Italian
Hindi
Japanese
Korean
Portuguese
Swedish
Turkish
Ukrainian
Simplified Chinese
Traditional Chinese

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@swrno swrno changed the title Converted about block into all available language Converted 'About Block' into all available language Dec 8, 2023
@swrno
Copy link
Contributor Author

swrno commented Dec 19, 2023

@lindapaiste @raclim Can you please review the PR? and give your feedback.

@raclim
Copy link
Collaborator

raclim commented Jan 25, 2024

Thanks for your work on this!

I think it would be great to get this one in before the upcoming release on February 15! I just merged in #2691, which starts these changes in the 'About' modal and I think caused some merge conflicts here. Would you be able to resolve them before the release?

@swrno
Copy link
Contributor Author

swrno commented Jan 25, 2024

Thanks for your work on this!

I think it would be great to get this one in before the upcoming release on February 15! I just merged in #2691, which starts these changes in the 'About' modal and I think caused some merge conflicts here. Would you be able to resolve them before the release?

Yes definitely, I would resolve it by tonight.

@swrno
Copy link
Contributor Author

swrno commented Jan 25, 2024

conflicts resolved!

@raclim raclim added the Area: Translation For localization of the p5.js editor or contributor documentation label Jan 26, 2024
@raclim raclim removed this from the MINOR Release for 2.12.0 milestone Mar 8, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds back in the "Donate" link that was added and removed with the fundraiser campaign, but ideally we do want to keep this in so I think it's great that this is here!

I did intend to merge this a while back so I'm going to get this in! There could be a few translation issues, but I'm hoping they could be raised down the line.

@raclim raclim merged commit b27492a into processing:develop Mar 28, 2024
@swrno swrno deleted the about-fix branch March 28, 2024 17:05
@raclim raclim added this to the MINOR Release for 2.13.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Translation For localization of the p5.js editor or contributor documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translating the 'About Block' into all possible type of language

2 participants