Skip to content

Fix : [#2986] Add ref callback #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Fix : [#2986] Add ref callback #2988

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da3f4f3
Fix : [#2986] Add ref callback
Ri-Sharma Feb 4, 2024
aa439b3
Merge branch 'develop' into Issue#2986
raclim Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions client/modules/IDE/components/CollectionList/CollectionListRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ const CollectionListRowBase = (props) => {
closeAll();
setRenameOpen(true);
setRenameValue(props.collection.name);
if (renameInput.current) {
renameInput.current.focus();
}
};

const handleRenameChange = (e) => {
Expand All @@ -146,6 +143,12 @@ const CollectionListRowBase = (props) => {
}
};

const handleRenameFocus = () => {
if (renameInput.current) {
renameInput.current.focus();
}
};

const handleRenameBlur = () => {
updateName();
closeAll();
Expand Down Expand Up @@ -191,7 +194,10 @@ const CollectionListRowBase = (props) => {
onKeyDown={handleRenameEnter}
onBlur={handleRenameBlur}
onClick={(e) => e.stopPropagation()}
ref={renameInput}
ref={(node) => {
renameInput.current = node;
handleRenameFocus();
}}
Comment on lines +197 to +200
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the ref function get executed every time that the element is mounted? Like if you open it and close it and open it again, will it get focused the second time? I think so but I'm not certain off the top of my head.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it get focused the second time?

Yes, it will. The way it works is when the component gets mounted the ref callback is called with the input field as an parameter. And when the component gets unmounted the callback is called again with null as an parameter.

/>
)}
</>
Expand Down