Skip to content

Delete unused callback on isSlugUnique function #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Delete unused callback on isSlugUnique function #3022

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b27ea1
Delete unused callback on `isSlugUnique` function.
lindapaiste Feb 14, 2024
fd50239
Merge branch 'develop' into cleanup/cb
raclim Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 10 additions & 24 deletions server/models/project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,34 +63,20 @@ projectSchema.pre('save', function generateSlug(next) {

/**
* Check if slug is unique for this user's projects
* @return {Promise<{ isUnique: boolean; conflictingIds: string[] }>}
*/
projectSchema.methods.isSlugUnique = async function isSlugUnique(cb) {
projectSchema.methods.isSlugUnique = async function isSlugUnique() {
const project = this;
const hasCallback = typeof cb === 'function';

try {
const docsWithSlug = await project
.model('Project')
.find({ user: project.user, slug: project.slug }, '_id')
.exec();
const docsWithSlug = await project
.model('Project')
.find({ user: project.user, slug: project.slug }, '_id')
.exec();

const result = {
isUnique: docsWithSlug.length === 0,
conflictingIds: docsWithSlug.map((d) => d._id) || []
};

if (hasCallback) {
cb(null, result);
}

return result;
} catch (err) {
if (hasCallback) {
cb(err, null);
}

throw err;
}
return {
isUnique: docsWithSlug.length === 0,
conflictingIds: docsWithSlug.map((d) => d._id) || []
};
};

export default mongoose.models.Project ||
Expand Down