Eye-Icon Alingnment

[Jatin24062005]

I make some little changes it is very begginer freindly issue . In which there are some protocols i have to follow dont use inline styling

Fixes #issue-number #3241
Changes:

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. `Fixes Icon Alignment Issue in Password Field – Adjust Eye Icon Vertical Centering #3241

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

[raclim]

Thanks for giving this a look and providing screenshots of your changes!

There's a few issues going on with this pull request, but I feel like one larger one here is that you remove the button's className tag and property .form__eye__icon on line 69 in LoginForm.jsx, but also make additional changes to it in _forms.scss despite not being accessible by the button anymore. Also, although the styling changes here do fix the issue at hand, we want to try to make sure that the alignment of the svg icon remains centered as well and doesn't shift towards the top, which is described in my comments for the associated issue.

I fixed a few of the linting errors, but we also strongly encourage ensuring that your work passes all the criteria listed in the checkboxes so your pull request is ready to go once you've submitted it.

I'm going to close this for now, but would encourage you to try to give this another try! If you decide to give this another look, I think that focusing on the .form__eye__icon property in _forms.scss and handling the svg properties from there would be a good starting point!