Skip to content

fix: escape key closes hints without blocking typing #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: escape key closes hints without blocking typing #3281

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8cfda5
fix: escape key closes hints without blocking typing
Leokhaidem Nov 23, 2024
e79b964
Merge branch 'develop' into leo/escape-key-issue1
raclim Nov 27, 2024
b7139e8
Merge branch 'develop' into leo/escape-key-issue1
raclim Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions client/modules/IDE/components/show-hint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,21 @@

// This is the old interface, kept around for now to stay
// backwards-compatible.

//event listener to enable escape key functionality
function addEscapeKeyListener(cm) {
const escapeHandler = (event) => {
if (event.key === 'Escape' && cm.state.completionActive) {
cm.closeHint(); // Close the hint
cm.focus(); // Ensure the editor regains focus
document.removeEventListener('keydown', escapeHandler); // Clean up listener
}
};

// Add the event listener when hints are active
document.addEventListener('keydown', escapeHandler);
}

CodeMirror.showHint = function (cm, getHints, options) {
if (!getHints) return cm.showHint(options);
if (options && options.async) getHints.async = true;
Expand Down Expand Up @@ -55,6 +70,8 @@

CodeMirror.signal(this, 'startCompletion', this);
completion.update(true);
// Add Escape key listener
addEscapeKeyListener(this);
});

CodeMirror.defineExtension('closeHint', function () {
Expand Down