Skip to content

Conversation

ajinkya22-dev
Copy link
Contributor

Progress towards #3510

Changes:

  • Replaced "SubmitSaveAllSettings" with "SaveAccountDetails" in the German locale file.
  • Updated "Settings" from "Account Einstellungen" to "Mein Konto" in the AccountView section of the German locale file.
  • The translations are now consistent across the German language and match the English version.
    The UI should now display the correct text in German.

This solution is implemented with reference to the context and discussions in issue #3509.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #3510

- Replace 'SubmitSaveAllSettings' with 'SaveAccountDetails' in German locale
- Update 'Settings' from 'Account Einstellungen' to 'Mein Konto' in AccountView
- Aligns German translations with updated English UI terminology

Progress towards processing#3510
Copy link

welcome bot commented Sep 13, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Sep 26, 2025

@figuraetymologica Thanks again for your help with the German translation on the recent banner! If you have a moment, would you be able to give these translations a quick look to confirm if they’re correct?

@raclim raclim added the Area: Translation For localization of the p5.js editor or contributor documentation label Sep 26, 2025
@figuraetymologica
Copy link

Glad I was able to help and no problem at all!

The translations are looking overall sound.

My input would be that Kontoeinstellungen speichern might be more intuitive/appropriate than Kontodetails speichern. Kontodetails is reminiscent of banking (if I ask someone for their Kontodetails I’m asking for their bank account details) and googling the word overwhelmingly yields results associated with online banking. Then again, it is shorter and in the context of editing one‘s account information communicates the intended meaning. :-)

(I hope I didn‘t overdo it, I’m not trying to be nitpicky 🙂‍↕️)

@ajinkya22-dev
Copy link
Contributor Author

@figuraetymologica Thanks a lot for the valuable feedback!
You make a really good point about “Kontoeinstellungen speichern” being clearer and more intuitive than “Kontodetails speichern” especially considering the banking association. I’ll update the translation accordingly so that it’s more natural for German users.

ajinkya22-dev and others added 2 commits September 27, 2025 20:09
Replaced "Kontodetails speichern" with "Kontoeinstellungen speichern"
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @figuraetymologica for your insight! I don't think it was nitpicky at all—the context is extremely helpful, especially as someone who does not know German! 😂

Thank you again @ajinkya22-dev for putting in this fix and for your quick follow up! I'm going to merge this in!

@raclim raclim merged commit fa70fe2 into processing:develop Oct 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Translation For localization of the p5.js editor or contributor documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants