Make CI build depends on test job in github actions #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseok44
changed the title
junseok44
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up of #971 and releated to #955
This PR adds a dependency to the build job in our GitHub Actions CI workflow, ensuring it only runs after the test job has successfully completed.
Previously, the
buildjob ran in parallel with thetestjob. While a test failure would eventually stop the workflow, the build process might have already started, consuming resources and time unnecessarily. This was particularly a concern with caching-related tests, where the build could make excessive API calls due to the unexpected caching behavior before confirming caching-related tests.By adding
needs: testto the build job, we now guarantee a sequential flow. The build process will only begin after all tests have passed, which leads to a more robust and efficient CI pipeline by preventing resource waste and ensuring that only code that meets our quality standards proceeds to the build stage.