-
Notifications
You must be signed in to change notification settings - Fork 178
Add auto-generated comments to reference MDX files #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for finishing this one @adi-ray ! Could you add a commit please with all the changes from Also, if you have time, please feel free to make the matching PR in |
One small clarification, on the 2.0 branch we'll want to run |
@adi-ray Hmm, could you try the below please?
I only get the above error when I run the build:reference script, then quit the process unexpectedly, and run it again. Otherwise, it has no errors. The filepath of the cloned library I could figure out from here: p5.js-website/src/scripts/utils.ts Line 30 in e1d02aa
If you're interested, you are welcome to investigate this issue and add some improved cleanup in |
Thanks @ksen0! That was exactly the issue. After the cleanup, it worked perfectly! |
@adi-ray That one I can't reproduce at the moment on this branch. If you are on a Windows machine, it might be a path normalization issue when |
Sorry for the notification noise, it was a mistake! Merging this in shortly |
Fixes #702
This implements message in English reference MDX files to prevent accidental edits.