Skip to content

Fix: Remove trailing slashes from external URLs to prevent 404 errors #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Remove trailing slashes from external URLs to prevent 404 errors #997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e44c8c2
Prevent breaking external links
hxrshxz Oct 11, 2025
e9c47c4
Update src/middleware.ts
hxrshxz Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions src/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,11 @@ export async function onRequest(
currentLocale = pathSegments[0];
}

let modifiedHtml = html;

// If we have a currentLocale, modify the HTML to ensure all links
// have the correct locale prefix
if (currentLocale) {
modifiedHtml = ensureCorrectLocalePrefixesInHtmlLinks(html, currentLocale);
}
// Process HTML links to normalize external URLs and add locale prefixes when applicable
const modifiedHtml = ensureCorrectLocalePrefixesInHtmlLinks(
html,
currentLocale,
);

// Return a new Response with the modified HTML
return new Response(modifiedHtml, {
Expand All @@ -56,7 +54,7 @@ export async function onRequest(

export const ensureCorrectLocalePrefixesInHtmlLinks = (
html: string,
currentLocale: string,
currentLocale?: string,
) => {
const $ = load(html);

Expand All @@ -65,13 +63,24 @@ export const ensureCorrectLocalePrefixesInHtmlLinks = (
$("a").each(function () {
let href = $(this).attr("href");
// Skip if href is undefined, an external link, or written with a dot slash
if (
!href ||
href.startsWith("http") ||
href.startsWith("./") ||
href.startsWith("#")
)
if (!href || href.startsWith("./") || href.startsWith("#")) return;

// Remove trailing slashes from external/absolute URLs (like Wikipedia)
// to prevent breaking external links
if (href.startsWith("http")) {
try {
const urlObj = new URL(href);
// Only remove trailing slash if the path is not just "/"
if (href.endsWith("/") && urlObj.pathname !== "/") {
href = href.slice(0, -1);
$(this).attr("href", href);
}
} catch (e) {
// If URL parsing fails, log the error and leave the href unchanged
console.error(`Failed to parse URL in <a> tag href: "${href}". Error:`, e);
}
return;
}

const startsWithLocale = nonDefaultSupportedLocales.some(
(locale) => href && href.startsWith(`/${locale}/`),
Expand Down