Skip to content

Adding framebuffer support for filter() + CreateFilterShader for 2D mode #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 23, 2023
Merged

Adding framebuffer support for filter() + CreateFilterShader for 2D mode #6559

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
198e456
Adding framebuffer support in filter
perminder-17 Nov 16, 2023
8b71469
Update p5.RendererGL.js
perminder-17 Nov 16, 2023
0ec719e
Update material.js
perminder-17 Nov 17, 2023
96bc262
Update p5.RendererGL.js
perminder-17 Nov 17, 2023
72cd97b
Reset matrix.js
perminder-17 Nov 18, 2023
6f0b715
Added test for filterCamera.js
perminder-17 Nov 18, 2023
2789e2a
Checking if pixelDensity is defined.js
perminder-17 Nov 20, 2023
2df0b03
Update p5.RendererGL.js
perminder-17 Nov 21, 2023
f42da57
Update material.js
perminder-17 Nov 21, 2023
cefc285
Update p5.RendererGL.js
perminder-17 Nov 21, 2023
9a86b19
merging
perminder-17 Nov 21, 2023
75b0042
Delete lib/empty-example/sketch.js
perminder-17 Nov 21, 2023
ae37304
function matchsize().js
perminder-17 Nov 21, 2023
e807740
fixed typo.js
perminder-17 Nov 22, 2023
1af2155
some fixes
perminder-17 Nov 22, 2023
7fa39f6
Update p5.RendererGL.js
perminder-17 Nov 22, 2023
683ed18
restore.js
perminder-17 Nov 22, 2023
c250531
Update p5.RendererGL.js
perminder-17 Nov 22, 2023
e4291cd
resizeCanvas to resize.js
perminder-17 Nov 22, 2023
b073664
fixes.js
perminder-17 Nov 23, 2023
a353711
fixes.js
perminder-17 Nov 23, 2023
4a9bef9
lint fix.js
perminder-17 Nov 23, 2023
2a330bf
Rename tests.js
perminder-17 Nov 23, 2023
6d04ec6
fixes.js
perminder-17 Nov 23, 2023
b1ec441
add test.js
perminder-17 Nov 23, 2023
c01235f
fixes.js
perminder-17 Nov 23, 2023
8df7437
fixes.js
perminder-17 Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/unit/webgl/p5.RendererGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,15 @@ suite('p5.RendererGL', function() {
assert.deepEqual([g1.width, g1.height], [g2.width, g2.height]);
});

test('Filter graphics layer get resized in 2D mode', function () {
let g1 = myp5.createCanvas(10, 10);
let s = myp5.createShader(vert, frag);
myp5.filter(s);
myp5.resizeCanvas(5, 15);
assert.equal(g1.width, 5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we only care that the sizes are equal when we want to do a filter, so you might need to call myp5.filter(s) again before this assertion

assert.equal(g1.height, 15);
});

test('create graphics is unaffected after filter', function() {
myp5.createCanvas(5, 5, myp5.WEBGL);
let pg = myp5.createGraphics(5, 5, myp5.WEBGL);
Expand Down