-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Improve Accessibility Guidance for describe()
Usage
#8101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NalinDalal
wants to merge
18
commits into
processing:dev-2.0
Choose a base branch
from
NalinDalal:dev-2.0
base: dev-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+287
−167
Open
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
06019f3
Add fontWidth() and clarify textWidth vs fontWidth docs in attributes.js
NalinDalal 8f24e3e
Merge branch 'processing:dev-2.0' into dev-2.0
NalinDalal 0aaf553
updated as per maintainers comment, only documentation is updated
NalinDalal 486e2db
Add fontWidth() and clarify textWidth vs fontWidth docs in attributes…
NalinDalal 944779c
Merge branch 'processing:dev-2.0' into dev-2.0
NalinDalal 6633de2
aded docs for difference between textWidth and fontWidth with respect…
NalinDalal eb58aba
unnecesaary file introduced, removed it, cleanedup the thing i was su…
NalinDalal 78ce6ac
Merge branch 'processing:dev-2.0' into dev-2.0
NalinDalal 2759e37
docs updated as asked
NalinDalal 3da06c0
removed things from previous pr
NalinDalal f911702
i think done, if not will ask maintainer
NalinDalal a0fae01
Merge branch 'dev-2.0' into dev-2.0
NalinDalal b218819
check, merge conflicts
NalinDalal cebc00c
Merge branch 'dev-2.0' into dev-2.0
NalinDalal e2bd6b1
Merge branch 'dev-2.0' into dev-2.0
NalinDalal 8549b93
updated the docs as per suggesstion from perminder
NalinDalal cf75292
Merge branch 'dev-2.0' of https://github.com/NalinDalal/p5.js into de…
NalinDalal 51534d6
Merge branch 'processing:dev-2.0' into dev-2.0
NalinDalal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2731,4 +2731,4 @@ export default textCore; | |
|
||
if (typeof p5 !== 'undefined') { | ||
textCore(p5, p5.prototype); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, this documentation is a more detailed doc than the above. What about something like: "
describe()
is one of the ways that p5.js sketches can be made accessible to screen readers. All contributions to the reference should include accessible canvas descriptions (see: Documentation Style Guide: Canvas Accessibility Descriptions)" - more focusing on the motivation of the style guide and its audience, than on passive description of its contentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it