Skip to content

fixed the bug of black-frames #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev-2.0
Choose a base branch
from
Open

fixed the bug of black-frames #8132

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa8d9a5
fixed the bug of black-frames
ayushman1210 Oct 8, 2025
c48acf7
Merge branch 'dev-2.0' into fix/black-frame_dev-2.0
perminder-17 Oct 14, 2025
7ddc2a0
fixed the bug-frame as maintainer-suggested
ayushman1210 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/image/loading_displaying.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,8 @@ function loadingDisplaying(p5, fn){
units: 'seconds',
silent: false,
notificationDuration: 0,
notificationID: 'progressBar'
notificationID: 'progressBar',
reset:true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reset:true
reset: true

}
) {
// validate parameters
Expand All @@ -273,7 +274,7 @@ function loadingDisplaying(p5, fn){
const silent = (options && options.silent) || false;
const notificationDuration = (options && options.notificationDuration) || 0;
const notificationID = (options && options.notificationID) || 'progressBar';

const resetAnimation = (options && options.reset !== undefined) ? options.reset : true;
// if arguments in the options object are not correct, cancel operation
if (typeof delay !== 'number') {
throw TypeError('Delay parameter must be a number');
Expand Down Expand Up @@ -324,11 +325,19 @@ function loadingDisplaying(p5, fn){
// that duration translates to
const nFrames = units === 'seconds' ? duration * _frameRate : duration;
const nFramesDelay = units === 'seconds' ? delay * _frameRate : delay;
const totalNumberOfFrames = nFrames + nFramesDelay;

// initialize variables for the frames processing
let frameIterator = nFramesDelay;
this.frameCount = frameIterator;
let frameIterator;
let totalNumberOfFrames;
if (resetAnimation) {
frameIterator = nFramesDelay;
this.frameCount = frameIterator;
totalNumberOfFrames = nFrames + nFramesDelay;
} else {
frameIterator = this.frameCount + nFramesDelay;
totalNumberOfFrames = frameIterator + nFrames;
}


const lastPixelDensity = this._renderer._pixelDensity;
this.pixelDensity(1);
Expand Down Expand Up @@ -381,7 +390,7 @@ function loadingDisplaying(p5, fn){
to be drawn and immediately save it to a buffer and continue
*/
this.redraw();

await new Promise(resolve => requestAnimationFrame(resolve));
// depending on the context we'll extract the pixels one way
// or another
let data = undefined;
Expand Down
Loading