-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(typography): add PRETTY/BALANCE textWrap modes with DP-based balanced wrapping #8297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vansh0204
wants to merge
3
commits into
processing:main
Choose a base branch
from
Vansh0204:feat/textwrap-pretty-balance-pr2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+178
−0
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
da64a0f
feat(typography): add PRETTY/BALANCE textWrap modes with DP-based bal…
Vansh0204 ceb5ae9
Add PRETTY/BALANCE constants and manual tests for textWrap/textAlign
Vansh0204 be03095
Fix: Use uppercase values for PRETTY/BALANCE constants per naming con…
Vansh0204 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <script language="javascript" type="text/javascript" src="../../../lib/p5.js?v=123456"></script> | ||
| <script language="javascript" type="text/javascript" src="sketch.js?v=123456"></script> | ||
| <style> | ||
| body { | ||
| padding: 0; | ||
| margin: 0; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <script>console.log("HTML loaded");</script> | ||
| </body> | ||
|
|
||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| function setup() { | ||
| console.log('Setup called'); | ||
| createCanvas(1000, 1200); | ||
| background(255); | ||
| textSize(14); | ||
| textFont('sans-serif'); | ||
|
|
||
| let alignments = [LEFT, CENTER, RIGHT]; | ||
| let vertAlignments = [BASELINE, BOTTOM, CENTER, TOP]; | ||
| // Using string literals as constants might not be exposed in this build environment yet | ||
| let wrapModes = ['pretty', 'balance']; | ||
| console.log('window.PRETTY:', window.PRETTY); | ||
| let sampleText = 'text gonna wrap when it gets too long and is then breaking.'; | ||
|
|
||
| let xStart = 50; | ||
| let yStart = 50; | ||
| let boxWidth = 200; | ||
| let boxHeight = 80; | ||
| let xGap = 220; | ||
| let yGap = 100; | ||
|
|
||
| // Test PRETTY and BALANCE with different alignments | ||
| for (let w = 0; w < wrapModes.length; w++) { | ||
| let mode = wrapModes[w]; | ||
| let modeName = (mode === PRETTY) ? 'PRETTY' : 'BALANCE'; | ||
|
|
||
| fill(0); | ||
| noStroke(); | ||
| text(`textWrap(${modeName})`, xStart, yStart - 20); | ||
|
|
||
| for (let i = 0; i < vertAlignments.length; i++) { | ||
| for (let j = 0; j < alignments.length; j++) { | ||
| let x = xStart + j * xGap; | ||
| let y = yStart + i * yGap; | ||
|
|
||
| let horiz = alignments[j]; | ||
| let vert = vertAlignments[i]; | ||
|
|
||
| let horizName = (horiz === LEFT) ? 'LEFT' : (horiz === CENTER) ? 'CENTER' : 'RIGHT'; | ||
| let vertName = (vert === BASELINE) ? 'BASELINE' : (vert === BOTTOM) ? 'BOTTOM' : (vert === CENTER) ? 'CENTER' : 'TOP'; | ||
|
|
||
| stroke(255, 0, 0); | ||
| noFill(); | ||
| rect(x, y, boxWidth, boxHeight); | ||
|
|
||
| noStroke(); | ||
| fill(0); | ||
| textAlign(horiz, vert); | ||
| textWrap(mode); | ||
| text(`${horizName} ${vertName} ${sampleText}`, x, y, boxWidth, boxHeight); | ||
| } | ||
| } | ||
| yStart += 500; | ||
| } | ||
|
|
||
| // Test JUSTIFIED | ||
| fill(0); | ||
| noStroke(); | ||
| text('textAlign(JUSTIFIED)', xStart, yStart - 20); | ||
|
|
||
| let justifiedText = 'This is a longer text that should be justified when it wraps to multiple lines. It should look clean and aligned on both sides.'; | ||
|
|
||
| stroke(255, 0, 0); | ||
| noFill(); | ||
| rect(xStart, yStart, boxWidth, boxHeight * 2); | ||
|
|
||
| noStroke(); | ||
| fill(0); | ||
| textAlign(JUSTIFIED, TOP); | ||
| textWrap(WORD); | ||
| text(justifiedText, xStart, yStart, boxWidth, boxHeight * 2); | ||
|
|
||
| stroke(255, 0, 0); | ||
| noFill(); | ||
| rect(xStart + xGap, yStart, boxWidth, boxHeight * 2); | ||
|
|
||
| noStroke(); | ||
| fill(0); | ||
| textAlign(JUSTIFIED, TOP); | ||
| textWrap(PRETTY); | ||
| text(justifiedText, xStart + xGap, yStart, boxWidth, boxHeight * 2); | ||
|
|
||
| fill(0); | ||
| noStroke(); | ||
| textAlign(LEFT, TOP); | ||
| text('WORD', xStart, yStart + boxHeight * 2 + 10); | ||
| text('PRETTY', xStart + xGap, yStart + boxHeight * 2 + 10); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.