Skip to content

Conversation

Vaivaswat2244
Copy link
Contributor

Copy link
Contributor

@mingness mingness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some ideas to clarify about your work in relation to JUnit.

- VisualTestRunner: The central orchestration class that manages the entire test lifecycle, from capturing a sketch to comparing it against a baseline image and generating a final test result.
- ImageComparator: The custom, self-contained pixel matching engine that uses a pixelmatch-inspired algorithm implemented entirely in Java, eliminating external dependencies.
- SketchRunner: A dedicated PApplet instance that manages the execution of a user's sketch in an off-screen buffer, ensuring consistent, repeatable rendering for testing purposes.
- ProcessingTestSuite: A class for organizing and running multiple tests, simplifying the management of large test suites.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments about these test classes (VisualTestRunner and ProcessingTestSuite) and JUnit? You mentioned you had some difficulty with JUnit in the call, could you go into detail here? In our chats, I thought these would work WITH JUnit, but now I'm not sure, after seeing your future work bullet point on JUnit and not using these classes. We ourselves talked about how we would use JUnit, but from the call yesterday, it is apparent that it is not clear that we will use JUnit, and that there is a preference for using JUnit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll add the required explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants