Skip to content

Conversation

awood0727
Copy link
Contributor

@awood0727 awood0727 commented Aug 5, 2025

Resolves

This PR resolves #1190

Changes

  • Modified line 211 in java/src/processing/mode/java/debug/LineBreakpoint.java to allow .pde files to return its filename
  • Inserted a new function in java/src/processing/mode/java/debug/Debugger.java to check and translate PDE files if they are mismatched with their folder.

Tests

  • We ran ./gradlew test, built successfully.
  • Ran ./gradlew run, built IDE successfully.
  • Tested the debugger to notice any change in its behavior.

Screenshots

Before Implementation

image

After Implementation

1190 issue solution

Signed-off-by: Amante' Woodley <[email protected]>

Co-authored-by: Nia Perez <[email protected]>
Co-authored-by: Kayla Bobo <[email protected]>
Co-authored-by: Silas Morgan <[email protected]>
@SableRaf SableRaf requested a review from Stefterv August 5, 2025 17:54
@Stefterv
Copy link
Collaborator

hi @awood0727 and crew, thank you for fixing this! I just have a quick question about the Debugger.pdeToSketchLine, it seems to not be used/referenced anywhere and your fix works without it too, could you clarify why this was added?

@awood0727
Copy link
Contributor Author

Hello @Stefterv, our thought process with the Debugger.pdeToSketchLine code was due to us creating a similar return line for the .pde files like was given for the .java files in LineBreakpoint.java we assumed that we needed to also create a similar function in Debugger. However if you believe that functions is not needed than we can take the code out if you would like us too.

@Stefterv
Copy link
Collaborator

Yeah if the function is unused, which it seems to be, please remove it. Great work!

@awood0727
Copy link
Contributor Author

Apologies for the delay but the fix should be implemented by the end of the week, my classes started a couple weeks ago so I'm trying to find a good time.

@awood0727 awood0727 mentioned this pull request Sep 5, 2025
3 tasks
@awood0727
Copy link
Contributor Author

Hey @Stefterv, we have created a pull request with the appropriate changes in PR #1227 thank you for all of your help and we hope you all are having an amazing weekend!

@Stefterv
Copy link
Collaborator

Stefterv commented Sep 8, 2025

Hey @awood0727 great thank you! Can you please close this PR then?

@awood0727
Copy link
Contributor Author

Will do thanks again!

@awood0727 awood0727 closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debugger does not work if Sketch name and folder are not equal

2 participants