mod_unified_push: increase max expiration to 60 days and default 7 days#373
Open
stratself wants to merge 1 commit intoprocessone:masterfrom
Open
mod_unified_push: increase max expiration to 60 days and default 7 days#373stratself wants to merge 1 commit intoprocessone:masterfrom
stratself wants to merge 1 commit intoprocessone:masterfrom
Conversation
stratself
changed the title
Signed-off-by: stratself <126093083+stratself@users.noreply.github.com>
itd0
reviewed
Mar 28, 2026
|
|
||
| -spec mod_opt_type(atom()) -> econf:validator(). | ||
| mod_opt_type(expiration) -> | ||
| %% TODO is there an upper bound for the validity of the JWT token? |
There was a problem hiding this comment.
Thanks for the PR and sorry for being a buzzkill, but I would rather not drop this TODO (or any of the other TODOs) without giving an answer in the commit message or related pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
If you'd rather use proper datetime formats (e.g.
60d) feel free to supercede this PR