Merged
Conversation
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
``` ==500714== Invalid free() / delete / delete[] / realloc() ==500714== at 0x484A78B: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==500714== by 0x5BDCD58: g_free (in /usr/lib64/libglib-2.0.so.0.8200.2) ==500714== by 0x49016B: http_file_put (http_upload.c:175) ==500714== by 0x5F613B1: start_thread (in /usr/lib64/libc.so.6) ==500714== by 0x5FE63D3: clone (in /usr/lib64/libc.so.6) ==500714== Address 0x86f6510 is 0 bytes inside a block of size 53 free'd ==500714== at 0x484A78B: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==500714== by 0x5BDCD58: g_free (in /usr/lib64/libglib-2.0.so.0.8200.2) ==500714== by 0x490299: http_file_put (http_upload.c:324) ==500714== by 0x5F613B1: start_thread (in /usr/lib64/libc.so.6) ==500714== by 0x5FE63D3: clone (in /usr/lib64/libc.so.6) ==500714== Block was alloc'd at ==500714== at 0x48477C4: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==500714== by 0x5F548A7: __vasprintf_internal (in /usr/lib64/libc.so.6) ==500714== by 0x5C2DD1D: g_vasprintf (in /usr/lib64/libglib-2.0.so.0.8200.2) ==500714== by 0x5BF8D97: g_strdup_vprintf (in /usr/lib64/libglib-2.0.so.0.8200.2) ==500714== by 0x5BF8E58: g_strdup_printf (in /usr/lib64/libglib-2.0.so.0.8200.2) ==500714== by 0x490264: http_file_put (http_upload.c:318) ==500714== by 0x5F613B1: start_thread (in /usr/lib64/libc.so.6) ==500714== by 0x5FE63D3: clone (in /usr/lib64/libc.so.6) ``` Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* use `calloc()` to allocate zero-initialized structs. * order the allocation of members by their declaration. * order the freeing of members in reverse order. * move init of `silent` flag in plugin case. * fix double free of `tmpname` in `aesgcm_file_get()`. * make some functions static. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
`http_dl->bytes_received` was already free'd when it was accessed inside `aesgcm_file_get()`. Change `http_file_get()` to optionally return the number of bytes received so we know how much data we have to decrypt. This fixes #1994 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
jubalh
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check commit messages for details.