Fix OTR whitespace tag detection to prevent false positives #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this related to #1957 ? If yes, could you reference the issue in the commit message? |
aryansri05
force-pushed
the
fix-otr-whitespace-detection
branch
from
c2345c1 to
c8b4b37
Compare
Contributor
Author
|
Updated the commit message to reference #1957. Thanks for the review! |
The previous implementation used strstr() which would match OTR tag patterns anywhere in the message. This caused normal messages containing these patterns to incorrectly trigger OTR session initialization. Changed to use strncmp() to verify that V1/V2 tags immediately follow the base tag, ensuring only legitimate OTR whitespace tags trigger session establishment. Fixes profanity-im#1957
sjaeckel
force-pushed
the
fix-otr-whitespace-detection
branch
from
c8b4b37 to
cff26a9
Compare
Member
|
I took the liberty to re-format your changes, so it passes CI. I hope that's OK for you :) |
Contributor
Author
|
No problem at all! Thanks for the help and for merging this. Really appreciate it! |
Member
|
Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes OTR whitespace tag false positive detection.
Problem
The current implementation uses
strstr()to detect OTR whitespace tags, which matches the pattern anywhere in the message. This causes normal user messages containing these patterns to incorrectly trigger OTR session initialization.Solution
Changed to use
strncmp()to verify that V1/V2 tags immediately follow the base tag, ensuring only legitimate OTR whitespace tags trigger session establishment.Testing
Built and tested on macOS with libotr 4.1.1.