-
Notifications
You must be signed in to change notification settings - Fork 0
Bug/blocking calls #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes blocking HTTP calls by implementing asynchronous telemetry sending on the RP2040 platform. The key changes focus on moving HTTP POST operations to a separate core to prevent blocking the main application loop.
- Introduces a lock-free SPSC queue for telemetry data on RP2040 with core-1 worker thread
- Refactors configuration from separate host/port to unified base URL
- Maintains synchronous behavior on ESP8266/ESP32 platforms for compatibility
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/OtelSender.cpp | Complete rewrite implementing async queue system and multi-core support for RP2040 |
| include/OtelSender.h | Adds queue management, worker thread controls, and async API definitions |
| platformio.ini | Updates configuration from separate host/port to unified base URL |
| library.json | Version bump and author name update |
| README.md | Documents new concurrency features and configuration options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.