Added remap support for hotkeys (backlight brightness, screenshot, etc) and ability to disable certain hotkeys#240
Open
Starbit04 wants to merge 3 commits intoprofi200:masterfrom
Open
Added remap support for hotkeys (backlight brightness, screenshot, etc) and ability to disable certain hotkeys#240Starbit04 wants to merge 3 commits intoprofi200:masterfrom
Starbit04 wants to merge 3 commits intoprofi200:masterfrom
Conversation
Updated readme to reflect new hotkey settings
|
Hey I was wondering if you'd be able to provide the compiled firm file for this version you've created as I have zero knowledge on how to compile this myself. |
Author
Hi, I've added a build to my repo |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried remapping X to B on my 3DS and realised it conflicted with the hotkeys for controlling the backlight, so I decided to make a fix by adding an option to enable/disable the backlight hotkeys, along with the screenshot hotkey for consistency.
I then added the ability to remap each existing hotkey to a different button combo, since I noticed some people were wanting it (#202 and #172) and seemed like a better solution to the initial problem. I've still kept the option for disabling the hotkeys though, since it could still be useful for who wouldn't want to adjust the backlight in-game or take screenshots.
This is the first time I've done a pull request for an open source project, so apologies if there's something I haven't done correctly. I've compiled and tested my changes on real hardware (original 3DS XL) and all seems to be good, and I've updated the readme to reflect my changes.