Skip to content

ci: add basic workflow#8

Draft
felipebergamin wants to merge 1 commit intomainfrom
ci/add-gh-actions
Draft

ci: add basic workflow#8
felipebergamin wants to merge 1 commit intomainfrom
ci/add-gh-actions

Conversation

@felipebergamin
Copy link
Member

@felipebergamin felipebergamin commented Nov 17, 2022

Description

Implements a GitHub Actions Workflow to check code healthy.

This workflow performs the following steps:

  1. Setup: run yarn install and yarn install-peers
  2. Build: runs yarn build, which generates both esm and cjs distributions
  3. dry run a publish: performs a publish action without actually publishing to npm, prints what would be published

In the end of steps 1 and 2, checks if git workspace is clean.

@felipebergamin felipebergamin force-pushed the ci/add-gh-actions branch 8 times, most recently from 88f096b to 5902020 Compare November 17, 2022 17:15
- name: Ensure project is clean
uses: numtide/clean-git-action@v1

publish-dry-run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should only publish in case we add a git tag to commit and not on every merge/release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! I'll change this job to run when a git tag is pushed

@felipebergamin felipebergamin force-pushed the ci/add-gh-actions branch 2 times, most recently from 2b2b55d to b5374ba Compare November 24, 2022 20:45
@felipebergamin felipebergamin force-pushed the ci/add-gh-actions branch 4 times, most recently from e0bcf63 to bf8407f Compare November 24, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants