Shared components 추가 (Button, BottomTabBar, AppBar, SegmentedControl, SnakBar, Toast)#18
Merged
devgony merged 22 commits intoprography:mainfrom Jun 26, 2025
Merged
Conversation
devgony
force-pushed
the
shared-components-1
branch
from
cf7212f to
443895a
Compare
…a design - Rename TabBar component to BottomTabBar - Fix tab order bug where tabs would rearrange based on type - Maintain consistent tab order (Goal, Group, Feed, MyPage) with only active state changing - Update Button component to match Figma specifications: - Apply correct padding, font-size, and height for each size - Integrate design tokens for consistent styling - Improve focus ring styling with proper colors - Update Button stories with Figma labels and comprehensive examples - Remove old TabBar files and update exports
… design tokens - Convert BottomTabBar, AppBar, SegmentedControl, SnackBar, Toast to Tailwind CSS - Integrate design tokens from tokens.css for consistent styling - Remove all style.css files and CSS imports - Improve accessibility with proper focus styles - Use cn utility for conditional class merging - Maintain responsive design and hover/active states - Ensure consistent typography using font-SUIT_Variable
devgony
changed the title
Collaborator
|
스타일은 tailwind안쓰시고 css로 하신 이유가 있나요? |
Collaborator
Author
엇.. css 로 되어있는 부분이 있나요? |
Collaborator
|
확인했습니답 ㅎㅎ |
Hys-Lee
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo