Onboarding 중복 클릭 방지 가드 추가

[devgony]

Todo

• 다음 버튼 API 호출 시 중복 클릭 방지
• 기간 선택 버튼들 중복 클릭 방지
• 달력 날짜 선택 중복 클릭 방지
• 달력 월 네비게이션 중복 클릭 방지 (200ms 딜레이)
• 제출 중 로딩 상태 표시 ("처리 중...")
• 에러 발생 시 상태 복구로 재시도 가능

Summary by CodeRabbit

• New Features

  • Improved UI responsiveness by disabling buttons and controls during form submission and navigation.
  • Added visual feedback and button state changes to prevent duplicate actions and enhance user experience during asynchronous operations.

• Chores

  • Updated script to ensure environment variables from .env.dev are loaded when running the generator command.

[coderabbitai]

Walkthrough

The updates introduce enhanced UI state management to the period selection component, adding safeguards against user actions during asynchronous operations such as form submission and calendar navigation. Additionally, the gen script in package.json now loads environment variables from .env.dev before running the generator script.

Changes

File(s)	Change Summary
app/onboarding/_components/PeriodSelectionScreen.tsx	Added state variables and handler functions to manage UI interaction states during async operations; disabled controls and added debouncing to prevent rapid actions.
package.json	Updated gen script to load environment variables from .env.dev using dotenv before execution.

Poem

A bunny hopped and pressed “Next” with glee,
But now must wait for the form to be free.
With buttons now dimmed, and calendars calm,
No more double clicks—what a soothing balm!
And with dotenv’s aid, in scripts we trust,
Our code hops forward, robust and just!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

app/onboarding/_components/PeriodSelectionScreen.tsx

(node:29486) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use node --trace-warnings ... to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.31.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

app/onboarding/_components/PeriodSelectionScreen.tsx (1)

262-291: Well-implemented submission protection with room for enhanced error handling.

The submission logic correctly prevents duplicate submissions and manages state appropriately. Consider enhancing the error handling to provide user feedback beyond console logging.

Consider adding user-visible error feedback:

            } catch (error) {
              console.error('Failed to create goal:', error);
+             // Show toast notification or error message to user
+             // Example: showErrorToast('목표 생성에 실패했습니다. 다시 시도해주세요.');
              setIsSubmitting(false);
              // Handle error appropriately (show toast, etc.)
            }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89992cf and d15d9d3.

📒 Files selected for processing (2)

• app/onboarding/_components/PeriodSelectionScreen.tsx (10 hunks)
• package.json (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

package.json (2)

Learnt from: CR
PR: prography/10th-Motimo-FE#0
File: .cursor/rules/global-rule.mdc:0-0
Timestamp: 2025-07-04T14:17:02.454Z
Learning: Applies to components/**/*.stories.{js,jsx,ts,tsx} : If Component is created, add storybook files as well.

Learnt from: CR
PR: prography/10th-Motimo-FE#0
File: .cursor/rules/global-rule.mdc:0-0
Timestamp: 2025-07-04T14:17:02.454Z
Learning: Applies to components/**/*.stories.{js,jsx,ts,tsx} : The first example name of storybook should be `Primary` not `Default`

🔇 Additional comments (14)

package.json (1)

14-14: LGTM! Consistent environment variable handling.

This change follows the existing pattern used by other scripts in the project and ensures environment variables are properly loaded during code generation.

app/onboarding/_components/PeriodSelectionScreen.tsx (13)

32-33: Well-implemented state management for duplicate prevention.

The new state variables clearly separate concerns between form submission and calendar navigation, providing granular control over UI interactions.

---

59-67: Excellent use of guard clauses for state protection.

The handler functions properly prevent state modifications during submission, ensuring data consistency throughout the async operation lifecycle.

---

110-111: Proper integration of duplicate click prevention in calendar.

The calendar day buttons correctly use the new handler and disabled state, providing both functional protection and visual feedback.

---

128-131: Smart debounce implementation for month navigation.

The 200ms debounce effectively prevents rapid consecutive month changes while the guard clause ensures navigation is blocked during form submission.

---

149-149: Correct integration of submission state in button logic.

The Next button enablement properly incorporates the submission state while preserving existing validation requirements.

---

171-186: Consistent implementation across period type selection.

The segmented control buttons properly implement the guard pattern with appropriate visual feedback during submission states.

---

220-231: Comprehensive state checking for navigation buttons.

The calendar navigation buttons properly check both navigation and submission states, ensuring robust protection against duplicate actions.

---

32-33: LGTM! Well-structured guard states.

The new state variables are properly initialized and follow clear naming conventions for preventing duplicate actions.

---

59-62: Excellent guard implementation for date selection.

The function properly prevents date changes during submission while maintaining clean, readable code with the early return pattern.

---

64-67: Consistent guard implementation for period type selection.

The function follows the same reliable pattern as handleDateSelect, ensuring consistent behavior across the component.

---

110-111: Well-implemented button state management.

The calendar buttons properly combine past date validation with submission guards, providing robust protection against invalid interactions.

---

220-224: Comprehensive button state management for navigation.

The disabled states properly account for all relevant conditions, ensuring consistent behavior with the navigation guard logic.

Also applies to: 231-231

---

171-176: Excellent integration of guard logic with visual feedback.

The period selection buttons properly use the centralized handler and provide clear visual feedback during disabled states.

Also applies to: 181-186

[coderabbitai]

🛠️ Refactor suggestion

Add cleanup for setTimeout to prevent memory leaks.

The navigation guard logic is well-implemented, but the setTimeout could cause issues if the component unmounts before the timeout completes.

+ const timeoutRef = useRef<NodeJS.Timeout | null>(null);
+
+ useEffect(() => {
+   return () => {
+     if (timeoutRef.current) {
+       clearTimeout(timeoutRef.current);
+     }
+   };
+ }, []);

  const navigateMonth = (direction: "prev" | "next") => {
    if (isNavigating || isSubmitting) return;
    
    setIsNavigating(true);
-   setTimeout(() => setIsNavigating(false), 200);
+   timeoutRef.current = setTimeout(() => setIsNavigating(false), 200);

Don't forget to import useRef and useEffect from React.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const navigateMonth = (direction: "prev" | "next") => {
	if (isNavigating || isSubmitting) return;
	setIsNavigating(true);
	setTimeout(() => setIsNavigating(false), 200);
	const timeoutRef = useRef<NodeJS.Timeout | null>(null);
	useEffect(() => {
	return () => {
	if (timeoutRef.current) {
	clearTimeout(timeoutRef.current);
	}
	};
	}, []);
	const navigateMonth = (direction: "prev" | "next") => {
	if (isNavigating || isSubmitting) return;
	setIsNavigating(true);
	timeoutRef.current = setTimeout(() => setIsNavigating(false), 200);

🤖 Prompt for AI Agents

In app/onboarding/_components/PeriodSelectionScreen.tsx around lines 127 to 131,
the setTimeout used to reset isNavigating lacks cleanup, risking memory leaks if
the component unmounts early. Fix this by storing the timeout ID in a useRef,
then use a useEffect hook to clear the timeout on component unmount. Also,
import useRef and useEffect from React at the top of the file.

[coderabbitai]

🛠️ Refactor suggestion

Ensure submission state is reset in all scenarios.

The submission logic has a potential issue where setIsSubmitting(false) is only called on error. If the API call succeeds, the component remains in the submitting state.

            try {
              await goalApi.createGoal({
                title: goal,
                isPeriodByMonth,
                month: isPeriodByMonth ? monthCount : undefined,
                dueDate,
                subGoals: [],
              });
              onNext();
            } catch (error) {
              console.error('Failed to create goal:', error);
-             setIsSubmitting(false);
              // Handle error appropriately (show toast, etc.)
+           } finally {
+             setIsSubmitting(false);
            }

Also, the guard at line 262 is redundant since the button is already disabled when isSubmitting is true. Consider removing it for cleaner code.

Also applies to: 262-265, 285-285, 291-291

🤖 Prompt for AI Agents

In app/onboarding/_components/PeriodSelectionScreen.tsx at line 149 and
surrounding submission logic, ensure that setIsSubmitting(false) is called in
both success and error paths of the API call to reset the submitting state
properly. Also, remove the redundant guard conditions around lines 262-265, 285,
and 291 that check isSubmitting before button actions, since the button is
already disabled when isSubmitting is true, simplifying the code.

[Hys-Lee]

일단 가시죠