-
Notifications
You must be signed in to change notification settings - Fork 2
Ec2 deploy 자동 배포 완성 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
포크한 레포에 작동 테스틀 위해 연결 스토리북 형태도 세팅함
구조 수정 및 tailwind prefix에 맞게 mapping
이전 패키지 버전에선 빌드가 안 됐음.
기존에 수도 클래스로 적용하면 씹히는 경우가 있어서 props를 직접 사용하는 방식으로 수정
5개 넘어야 보이도록
goalId 동일한 것으로 잡도록 수정 dueDate도 계산해서 추가
게스트 모드라면 쿼리 키 다르게 해 refetch 유도 게스트 모드 기록 체크 및 기록이 있다면 온보딩 생략 중복되는 closeMSW함수 제거
게스트 첫 진입 시 onNext실행하도록 수정
도커 허브는 제 개인으로 해두겠습니답
restart에 대해 always적용
docker관련 명령어에서 permission에러로 인해 sudo명령어 추가
…into ec2-deploy
기존 sudo를 사용하던 것에서 denied가 발생하여 명령어 바꾸고 추가로 빌드 시 환경변수 추가 ec2-deploy브랜치에서 우선 테스트
|
Caution Review failedThe pull request is closed. WalkthroughWorkflow updates in .github/workflows/production-deploy.yml replace manual Docker build/push with docker/build-push-action@v4 (including a build arg), adjust image tagging to use the commit SHA, and add a docker system prune on the EC2 host before pulling and restarting the container. The deploy sequence otherwise remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant DH as Docker Hub
participant EC2 as EC2 Host
participant Docker as Docker Engine
Dev->>GH: Push to production branch
GH->>GH: Build image (docker/build-push-action@v4)<br/>with build-arg from secrets
GH->>DH: Push image tagged with commit SHA
GH->>EC2: SSH and run deploy script
EC2->>Docker: system prune -a -f (cleanup)
EC2->>DH: Pull image by SHA tag
EC2->>Docker: Stop & remove existing container
EC2->>Docker: Run new container (ports, env-file)
note over EC2,Docker: Flow unchanged after prune
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
cd과정의 에러 모두 수정했습니다.
추가로 로그인 화면 제스처 바도 삭제했습니다.
Summary by CodeRabbit