Skip to content

Conversation

@Hys-Lee
Copy link
Collaborator

@Hys-Lee Hys-Lee commented Aug 29, 2025

ec2 인스턴스 용량 부족으로 인해 배포 순서 변경
기존 이미지 삭제 후 pull하는 방식으로 변경

Summary by CodeRabbit

  • Chores
    • Streamlined the production deployment pipeline to use a standardized Docker build-and-push action.
    • Added a pre-deployment cleanup to ensure old containers are removed before deploying the new version.
    • Removed redundant stop/remove steps and minor formatting cleanup.
    • Impact: Improves deployment reliability and consistency, reducing potential downtime during releases. No changes to product functionality or user experience.

Hys-Lee added 30 commits May 21, 2025 12:44
포크한 레포에 작동 테스틀 위해 연결
스토리북 형태도 세팅함
구조 수정 및 tailwind prefix에 맞게 mapping
이전 패키지 버전에선 빌드가 안 됐음.
Hys-Lee added 27 commits August 27, 2025 12:11
goalId 동일한 것으로 잡도록 수정
dueDate도 계산해서 추가
게스트 모드라면 쿼리 키 다르게 해 refetch 유도
게스트 모드 기록 체크 및 기록이 있다면 온보딩 생략
중복되는 closeMSW함수 제거
도커 허브는 제 개인으로 해두겠습니답
docker관련 명령어에서 permission에러로 인해 sudo명령어 추가
기존 sudo를 사용하던 것에서 denied가 발생하여 명령어 바꾸고 추가로 빌드 시 환경변수 추가
ec2-deploy브랜치에서 우선 테스트
기존에는 pull을 먼저 수행하고 기존의 컨테이너를 삭제했는데, 용량부족으로 순서 변경
@Hys-Lee Hys-Lee self-assigned this Aug 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates the production deployment workflow to use docker/build-push-action@v4 for building/pushing the image, introduces an early pre-deploy container stop/remove on EC2, removes a duplicate stop/remove block later in the script, and applies a minor formatting tweak.

Changes

Cohort / File(s) Summary of Changes
CI/CD workflow update
\.github/workflows/production-deploy.yml
Replaced manual Docker build/push with docker/build-push-action@v4 (with context, push, tags, and build-args). Added pre-deploy cleanup on EC2 to stop/remove motimo-fe-production before pull/run. Removed redundant stop/remove block after pull. Minor formatting cleanup.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub Actions
  participant DH as Docker Hub
  participant EC2 as EC2 Host

  Dev->>GH: Push to main / trigger workflow
  GH->>DH: Build & push image (docker/build-push-action@v4)\n(tags: ${DOCKERHUB_USERNAME}/motimo-fe-production:${{ github.sha }})
  Note right of GH: Pass build-args\nNEXT_PUBLIC_FRONTEND_BASE_URL

  GH->>EC2: SSH: Pre-deploy cleanup\n(stop & remove motimo-fe-production if running)
  GH->>EC2: Docker pull new image (by commit SHA tag)
  EC2->>EC2: Docker run motimo-fe-production\n(with existing run args)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hop through pipelines, light and keen,
New images baked, so fresh and clean.
Stop, remove—make room to run,
Pull the tag, deploy is done.
With whiskers twitching, logs all green—
Ship it swift, like a springtime scene. 🐇🚀


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c483b30 and aa970d6.

📒 Files selected for processing (1)
  • .github/workflows/production-deploy.yml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Hys-Lee Hys-Lee merged commit 6f08b8d into prography:main Aug 29, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant