-
Notifications
You must be signed in to change notification settings - Fork 2
Ec2 deploy 동작 순서 수정 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
포크한 레포에 작동 테스틀 위해 연결 스토리북 형태도 세팅함
구조 수정 및 tailwind prefix에 맞게 mapping
이전 패키지 버전에선 빌드가 안 됐음.
goalId 동일한 것으로 잡도록 수정 dueDate도 계산해서 추가
게스트 모드라면 쿼리 키 다르게 해 refetch 유도 게스트 모드 기록 체크 및 기록이 있다면 온보딩 생략 중복되는 closeMSW함수 제거
게스트 첫 진입 시 onNext실행하도록 수정
도커 허브는 제 개인으로 해두겠습니답
restart에 대해 always적용
docker관련 명령어에서 permission에러로 인해 sudo명령어 추가
…into ec2-deploy
기존 sudo를 사용하던 것에서 denied가 발생하여 명령어 바꾸고 추가로 빌드 시 환경변수 추가 ec2-deploy브랜치에서 우선 테스트
기존에는 pull을 먼저 수행하고 기존의 컨테이너를 삭제했는데, 용량부족으로 순서 변경
…into ec2-deploy
|
Caution Review failedThe pull request is closed. WalkthroughUpdates the production deployment workflow to use docker/build-push-action@v4 for building/pushing the image, introduces an early pre-deploy container stop/remove on EC2, removes a duplicate stop/remove block later in the script, and applies a minor formatting tweak. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant DH as Docker Hub
participant EC2 as EC2 Host
Dev->>GH: Push to main / trigger workflow
GH->>DH: Build & push image (docker/build-push-action@v4)\n(tags: ${DOCKERHUB_USERNAME}/motimo-fe-production:${{ github.sha }})
Note right of GH: Pass build-args\nNEXT_PUBLIC_FRONTEND_BASE_URL
GH->>EC2: SSH: Pre-deploy cleanup\n(stop & remove motimo-fe-production if running)
GH->>EC2: Docker pull new image (by commit SHA tag)
EC2->>EC2: Docker run motimo-fe-production\n(with existing run args)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
ec2 인스턴스 용량 부족으로 인해 배포 순서 변경
기존 이미지 삭제 후 pull하는 방식으로 변경
Summary by CodeRabbit