Skip to content

allow for custom protocol implementations to skip Has* methods #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow for custom protocol implementations to skip Has* methods #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions objc/protocol.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,11 @@ func respondsTo(goID uintptr, sel unsafe.Pointer) bool {
if mi.required {
return true
}
// invalid hasFunc means no HasXXX method, but the XXX method does exist.
// this indicates the optional method is implemented by this implementation.
if !mi.hasFunc.IsValid() {
return true
}

return mi.hasFunc.Call([]reflect.Value{v})[0].Bool()
}
Expand Down
Loading