Skip to content

Commit ca624d7

Browse files
committed
RSS: Fix nondeterministic test failures
Caused by 'rss announce add' triggering headline announces, that would delay the execution of the 'remove' commands. Thanks to @mapreri and @Unit193 for help in reproducing the issue and confirming the patch.
1 parent 0c8e455 commit ca624d7

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

plugins/RSS/test.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,14 @@ def testCantAddDuplicatedFeed(self):
103103

104104
@mock_urllib
105105
def testRemoveAliasedFeed(self, mock):
106-
mock._data = xkcd_new
106+
mock._data = xkcd_old
107107
try:
108108
self.assertNotError('rss announce add http://xkcd.com/rss.xml')
109+
110+
# Clear the queue or it's going to mess up the finally block
111+
self.assertRegexp(' ', 'Snake Facts')
112+
self.assertNoResponse(' ')
113+
109114
self.assertNotError('rss add xkcd http://xkcd.com/rss.xml')
110115
finally:
111116
self.assertNotError('rss announce remove http://xkcd.com/rss.xml')

0 commit comments

Comments
 (0)