Add docker instructions + fix instructions #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr includes the docker instructions from progval#72 but also includes some corrections to the existing instructions. It now details cloning the source code and moving into it but most importantly a critical step where the Containerfile needs to be copied to the root of the project folder to correctly build
|
@progval, could you check over the wording for this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes the docker instructions from #72 but also includes some corrections to the existing instructions. It now details cloning the source code and moving into it but most importantly a critical step where the Containerfile needs to be copied to the root of the project folder to correctly build.
It also reverts the "fix" made in commit 0a3989a since it doesn't change anything but does add minor complexity.