Updated discovery.proto. Removed optional label.#696
Open
auyidi1 wants to merge 1 commit intoproject-akri:mainfrom
Open
Updated discovery.proto. Removed optional label.#696auyidi1 wants to merge 1 commit intoproject-akri:mainfrom
auyidi1 wants to merge 1 commit intoproject-akri:mainfrom
Conversation
kate-goldenring
requested changes
Jun 7, 2024
Contributor
kate-goldenring
left a comment
There was a problem hiding this comment.
@auyidi1 thank you bringing this up as some libraries no longer allow optional fields unless a flag is set.
This change should also come with a rebuild of the generated code (cd discovery-utils && make build) and dependent changes to the discovery handler implementations. I know this is a delayed review. Let me know if you would like me to push those changes into here or whether you are happy to take this on.
Member
|
@auyidi1 would it be possible for you to push the changes Kate requested in her feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)