Skip to content

Updated discovery.proto. Removed optional label.#696

Open
auyidi1 wants to merge 1 commit intoproject-akri:mainfrom
auyidi1:main
Open

Updated discovery.proto. Removed optional label.#696
auyidi1 wants to merge 1 commit intoproject-akri:mainfrom
auyidi1:main

Conversation

@auyidi1
Copy link

@auyidi1 auyidi1 commented May 16, 2024

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auyidi1 thank you bringing this up as some libraries no longer allow optional fields unless a flag is set.

This change should also come with a rebuild of the generated code (cd discovery-utils && make build) and dependent changes to the discovery handler implementations. I know this is a delayed review. Let me know if you would like me to push those changes into here or whether you are happy to take this on.

@gauravgahlot
Copy link
Member

gauravgahlot commented Dec 6, 2025

@auyidi1 would it be possible for you to push the changes Kate requested in her feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants