Skip to content

Conversation

@rquidute
Copy link
Contributor

@rquidute rquidute commented Jan 8, 2026

What changed

This PR implements comprehensive FFmpeg validation and error handling:

  1. Pre-validation Check - FFmpeg is checked before WebSocket connection, preventing the stream from being marked as "ready" when FFmpeg is missing
  2. Clear User Feedback - Displays formatted installation instructions when FFmpeg is not detected
  3. Graceful Abort - Sends a CANCELLED response to the backend to properly abort test execution instead of hanging
  4. Exception Handling - Catches and handles all FFmpeg-related errors in the background async task

Also some minors formatting and import sort fixes was performed in this PR.

Related Issue

project-chip/certification-tool#844

Testing

Unit test passing

Message displayed to the user when no ffmpeg is found
Screenshot 2026-01-08 at 11 25 06

@rquidute rquidute requested a review from antonio-amjr January 8, 2026 14:35
@rquidute rquidute self-assigned this Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the video stream tests by implementing robust FFmpeg validation and error handling. These changes ensure that the test execution is aborted gracefully and the user is provided with actionable feedback when FFmpeg is not properly configured.

Highlights

  • FFmpeg Validation: Implements a pre-validation check for FFmpeg before establishing a WebSocket connection, preventing the stream from being marked as 'ready' when FFmpeg is missing.
  • User Feedback: Provides clear, formatted installation instructions to the user when FFmpeg is not detected.
  • Graceful Abort: Sends a CANCELLED response to the backend to properly abort test execution instead of hanging when video stream initialization fails.
  • Exception Handling: Implements comprehensive exception handling for FFmpeg-related errors within the background async task.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive error handling for FFmpeg in the video stream tests, which is a great improvement for robustness and user experience. The changes include pre-validating the FFmpeg installation, providing clear user feedback on missing dependencies, and gracefully aborting tests on failure. The implementation is solid and directly addresses the issue. I've added a couple of suggestions to further enhance maintainability by refactoring duplicated code and improving the robustness of exception handling.

@rquidute rquidute requested a review from antonio-amjr January 8, 2026 21:09
@rquidute rquidute requested a review from antonio-amjr January 9, 2026 14:11
@rquidute rquidute merged commit d8c82c6 into v2.15-cli-develop Jan 9, 2026
2 checks passed
@rquidute rquidute deleted the feature/844_add_ffmpeg_checking branch January 9, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants