Rename closure-dimension cluster files for conversion to code driven#43573
Open
pimpalemahesh wants to merge 3 commits intoproject-chip:masterfrom
Open
Rename closure-dimension cluster files for conversion to code driven#43573pimpalemahesh wants to merge 3 commits intoproject-chip:masterfrom
pimpalemahesh wants to merge 3 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Closure Dimension cluster files to align with the code-driven cluster style. The changes primarily involve renaming files, moving code into new files, and updating the old headers to act as wrappers for backward compatibility. The build file modifications are consistent with these changes. The refactoring is well-executed, and the identified minor copy-paste error in a file-level comment should be corrected for clarity.
src/app/clusters/closure-dimension-server/ClosureDimensionClusterLogic.h
Show resolved
Hide resolved
|
PR #43573: Size comparison from fa956ce to 0dc7778 Full report (5 builds for cc32xx, realtek, stm32)
|
pimpalemahesh
force-pushed
the
closure-dimension/rename-files
branch
from
0dc7778 to
c44c2fc
Compare
|
PR #43573: Size comparison from fa956ce to c44c2fc Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
reviewed
Mar 13, 2026
andy31415
approved these changes
Mar 13, 2026
Contributor
andy31415
left a comment
andy31415
left a comment
There was a problem hiding this comment.
Ok in general. I wonder if the header should go to Cluster or CodegenIntegration (historically leaning towards CodegenIntegration)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43573 +/- ##
=======================================
Coverage 54.07% 54.07%
=======================================
Files 1548 1548
Lines 106709 106709
Branches 13308 13308
=======================================
Hits 57704 57704
Misses 49005 49005 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sabollim-silabs
approved these changes
Mar 13, 2026
Contributor
@pimpalemahesh we have updated docs on renames: https://project-chip.github.io/connectedhomeip-doc/guides/migrating_ember_cluster_to_code_driven.html#part-0-optimizing-for-an-easier-review Provides more details on what to rename to what else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This MR renames the Closure Dimension cluster source files to follow the code driven cluster style.
Only file renames
Related issues
#43574
Testing
Successfully built closure-app locally.
CI should be enough as only file renames