ZoneMgmtCluster Migration PR#3 move structs#43590
Open
marybadalyan wants to merge 10 commits intoproject-chip:masterfrom
Open
ZoneMgmtCluster Migration PR#3 move structs#43590marybadalyan wants to merge 10 commits intoproject-chip:masterfrom
marybadalyan wants to merge 10 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily involves refactoring by moving code and renaming components to prepare for a code-driven implementation of the Zone Management cluster. The changes are generally well-structured, but I've identified a circular dependency issue in the new header files that should be addressed. Additionally, there's a minor typo in a comment.
src/app/clusters/zone-management-server/zone-management-server.h
Outdated
Show resolved
Hide resolved
|
PR #43590: Size comparison from 0d30044 to 8671a3d Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
Contributor
Author
|
/gemini review |
|
PR #43590: Size comparison from 0d30044 to cd558eb Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sum1cares
approved these changes
Mar 14, 2026
Sum1cares
approved these changes
Mar 14, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily refactors the Zone Management cluster by moving several structs and the delegate into separate header files, and relocating the ZoneMgmtServer class. These changes are a good step towards improving modularity. However, there is a critical inconsistency in the renaming of the delegate class. It has been renamed to ZoneMgmtDelegate in one file but remains Delegate in its new header and in the ZoneMgmtServer declaration. This will cause compilation failures and needs to be corrected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43590 +/- ##
=======================================
Coverage 54.12% 54.12%
=======================================
Files 1550 1550
Lines 106947 106947
Branches 13312 13312
=======================================
Hits 57888 57888
Misses 49059 49059 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marybadalyan
changed the title
andy31415
approved these changes
Mar 14, 2026
andy31415
reviewed
Mar 14, 2026
| using ZoneTriggerControlStruct = Structs::ZoneTriggerControlStruct::Type; | ||
| using ZoneInformationStruct = Structs::ZoneInformationStruct::Type; | ||
|
|
||
| ZoneMgmtServer::ZoneMgmtServer(ZoneMgmtDelegate & aDelegate, EndpointId aEndpointId, const BitFlags<Feature> aFeatures, |
Contributor
There was a problem hiding this comment.
Arm64 compile fails:
INFO ../../examples/camera-app/linux/third_party/connectedhomeip/src/app/clusters/zone-management-server/ZoneManagementCluster.cpp:47:32: error: unknown type name 'ZoneMgmtDelegate'
INFO 47 | ZoneMgmtServer::ZoneMgmtServer(ZoneMgmtDelegate & aDelegate, EndpointId aEndpointId, const BitFlags<Feature> aFeatures,
INFO
Make sure locally you try to compile camera app (or see if any other app includes this cluster).
|
PR #43590: Size comparison from 708056c to 9baa205 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes made:
This PR only does code movements and name changes in the codebase to make cluster migration more explicit .
TwoDCartesianZoneStoragestruct to it's headerZoneInformationStoragestruct to it's headerDelegateto it's own structZoneMgmtServertoCodegenIntegration.hfor later easier diffs in the code drive cluster implementation PRZoneMgmtCluster Migration PR#2 Code-Driven Implementation #43423.
Related issues
Fixes: #43194
Testing
No changes