Update rs-matter because esp-mbedtls just got renamed to mbedtls-rs

[ivmarkov]

Subject says it all. Since we renamed esp-mbedtls to mbedtls-rs (because it is no longer just for ESP MCUs), rs-matter CI will start failing unless we merge this.

This is really just an /sesp_mbedtls_sys/rmbedtls_rs_sys of sorts.

[gemini-code-assist]

Summary of Changes

Hello @ivmarkov, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the rs-matter project to align with a recent renaming of its mbedtls system binding dependency. The esp-mbedtls crate, originally specific to ESP microcontrollers, has been generalized and renamed to mbedtls-rs. This change ensures that the rs-matter project remains compatible with the updated dependency, preventing potential CI failures and reflecting the broader applicability of the underlying mbedtls bindings.

Highlights

• Dependency Renaming: The esp-mbedtls-sys dependency has been renamed to mbedtls-rs-sys across the project to reflect its broader applicability beyond ESP microcontrollers.
• Configuration Update: The Cargo.toml file was updated to reflect the new dependency name and its corresponding Git repository URL.
• Codebase Adaptation: All direct references to esp_mbedtls_sys within the rs-matter/src/crypto/backend/mbedtls.rs file have been updated to use mbedtls_rs_sys.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• rs-matter/Cargo.toml
  • Updated the mbedtls feature to depend on mbedtls-rs-sys instead of esp-mbedtls-sys.
  • Updated the defmt feature to reference mbedtls-rs-sys? instead of esp-mbedtls-sys?.
  • Changed the esp-mbedtls-sys dependency entry to mbedtls-rs-sys, updating its git URL from https://github.com/esp-rs/esp-mbedtls to https://github.com/esp-rs/mbedtls-rs.
• rs-matter/src/crypto/backend/mbedtls.rs
  • Replaced all occurrences of esp_mbedtls_sys:: with mbedtls_rs_sys:: for macro calls, use statements, struct field types, and function invocations related to MbedTLS.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/chiptool-tests.yml

Activity

• No specific activity (comments, reviews, progress) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the rs-matter crate to use the renamed mbedtls-rs crate, which was formerly esp-mbedtls. The changes correctly replace all occurrences of esp-mbedtls-sys with mbedtls-rs-sys in Cargo.toml and within the mbedtls crypto backend implementation. This is a necessary and correct dependency update to align with the upstream rename. The changes are straightforward and look good.

[github-actions]

PR #373: Size comparison from 4aaf4ad to 3d7b07a

Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)

platform	target	config	section	4aaf4ad	3d7b07a	change	% change
(core)	riscv32imac-unknown-none-elf	infodefmt-optz-ltofat	FLASH	378336	378316	-20	-0.0
			RAM	64712	64712	0	0.0
	thumbv6m-none-eabi	infodefmt-optz-ltofat	FLASH	317800	317792	-8	-0.0
			RAM	61240	61240	0	0.0
	thumbv7em-none-eabi	infodefmt-optz-ltofat	FLASH	291248	291236	-12	-0.0
			RAM	60728	60732	4	0.0
	x86_64-unknown-linux-gnu	infologs-optz-ltofat	FLASH	811399	811399	0	0.0
			RAM	64400	64400	0	0.0
dimmable-light	x86_64-unknown-linux-gnu	infologs-optz-ltofat	FLASH	1873216	1874160	944	0.1
			RAM	46584	46584	0	0.0
onoff-light	x86_64-unknown-linux-gnu	infologs-optz-ltofat	FLASH	1800288	1800928	640	0.0
			RAM	46576	46576	0	0.0
onoff-light-bt	x86_64-unknown-linux-gnu	infologs-optz-ltofat	FLASH	3112664	3113648	984	0.0
			RAM	9304	9304	0	0.0
speaker	x86_64-unknown-linux-gnu	infologs-optz-ltofat	FLASH	800480	801088	608	0.1
			RAM	2832	2832	0	0.0