move appwrapper finalizer injection from defaulting webhook to controller #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaulting webhooks can run in any order, therefore we can't rely using the value of managedBy seen by our defaulter to figure out whether or not we should add the appwrapper finalizer. To reduce reconciliation conflicts with Kueue, defer adding the finalizer until we are taking the Suspended to Resuming transition (which will only happen after Kueue's workload controller successfully updates Spec.Suspend).
dgrove-oss
changed the title
dgrove-oss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaulting webhooks can run in any order, therefore we can't rely using the value of managedBy seen by our defaulter to figure out whether or not we should add the appwrapper finalizer.
To reduce reconciliation conflicts with Kueue, defer adding the finalizer until we are taking the Suspended to Resuming transition (which will only happen after Kueue's workload controller successfully updates Spec.Suspend).