Adjust test timeout on AppWrappers to decrease e2e tests duration #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
requested review from
sutaakar
and removed request for
jbusche and
varshaprasad96
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrove-oss, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b7e3f34
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
No Jira
Context
Currently the e2e tests are taking around 45mins to complete. There's a test running for 15mins, of which is required to run for only 2mins.
In the deployment_appwrapper_test.go file, there is this test to make sure the AppWrapper continues to run for a set amount of time. The timeout set is
TestTimeoutMediumequal to 2m.However, in the e2e_tests.yaml workflow file, we've set the environment variable for TestTimeoutMedium, to be equal to 15mins, causing this test to always run for 15 minutes.
Change
Changed in the deployment_appwrapper_test.go file the timeout from
TestTimeoutMediumtoTestTimeoutShort.