-
Notifications
You must be signed in to change notification settings - Fork 58
Add annotations parameter #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations parameter #785
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 23 23
Lines 1345 1345
=======================================
Hits 1215 1215
Misses 130 130 ☔ View full report in Codecov by Sentry. |
KPostOffice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good. One comment though
73274da to
3479dec
Compare
3479dec to
c8b59d3
Compare
c8b59d3 to
ef02b38
Compare
ef02b38 to
7e49133
Compare
7e49133 to
e1572ea
Compare
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, KPostOffice, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
22a24d8
into
project-codeflare:main
Issue link
RHOAIENG-16029
What changes have been made
annotationsparameter for ClusterConfigurationVerification steps
Setup
Notebook server ODH/RHOAI/Local
git clone https://github.com/project-codeflare/codeflare-sdk.gitpoetry build- install if needed (pip install poetry)pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whlTesting
annotationsparameterannotations = {"key":"value"}Additional testing
Run the same testing steps above in a RHOAI notebook.
Ensure that the notebook managedby annotation is appended to the user defined annotations
Checks