Skip to content

Conversation

@LilyLinh
Copy link
Contributor

Issue link

jira

What changes have been made

  • Removed deprecated parameters: head_cpus & head_memory & associated deprecation logic& test file
  • Removed deprecated parameter references from docstrings

Verification steps

Run demo-notebook files, check that:

  • Existing code using new parameters (head_cpu_requests, etc.) continues to work
  • Code using deprecated parameters (head_cpus, head_memory) fails with clear error messages

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change
Screenshot 2025-08-25 at 16 33 29

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2025
@LilyLinh LilyLinh requested a review from chipspeak August 27, 2025 10:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szaher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LilyLinh LilyLinh closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants