Rhoaieng 30722 #923
Merged
Rhoaieng 30722 #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
LilyLinh
reviewed
Oct 9, 2025
LilyLinh
reviewed
Oct 9, 2025
LilyLinh
reviewed
Oct 9, 2025
LilyLinh
reviewed
Oct 9, 2025
LilyLinh
reviewed
Oct 9, 2025
LilyLinh
reviewed
Oct 9, 2025
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 25 25
Lines 1395 1395
=======================================
Hits 1290 1290
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pawelpaszki
approved these changes
Oct 10, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane, pawelpaszki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LilyLinh
force-pushed
the
RHOAIENG-30722
branch
2 times, most recently
from
b05d41f to
0e81c86
Compare
Contributor
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
LilyLinh
force-pushed
the
RHOAIENG-30722
branch
2 times, most recently
from
23c4fc2 to
70fe5b2
Compare
LilyLinh
force-pushed
the
RHOAIENG-30722
branch
from
70fe5b2 to
1d367c1
Compare
Contributor
|
/lgtm |
openshift-merge-bot
bot
merged commit 3ee3a36
into
project-codeflare:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-30722
What changes have been made
Remove existing references to 'cluster.up()' in output.
Adding to output that cluster.status() can also be used to check status of the cluster when trying to initialize the client
Verification steps
Run all the functions and check that the output is as expected.
Check test changes are appropriate and tests still passing.
Checks