Merged
Conversation
iangneal
requested changes
Nov 7, 2025
Contributor
iangneal
left a comment
iangneal
left a comment
There was a problem hiding this comment.
Handful of nits and comments but overall LGTM, pretty straightforward and easy to read.
Contributor
Author
|
@iangneal Feel free to do another pass. I added both failing and some more passing tests |
iangneal
approved these changes
Nov 10, 2025
Contributor
iangneal
left a comment
iangneal
left a comment
There was a problem hiding this comment.
LGTM, just one more comment
0xddom
reviewed
Nov 10, 2025
Contributor
0xddom
left a comment
0xddom
left a comment
There was a problem hiding this comment.
Some comments and questions. The general logic lgtm tho I think we are missing more TODOs than just calls
tim-hoffman
reviewed
Nov 10, 2025
tim-hoffman
reviewed
Nov 10, 2025
lib/Transforms/CMakeLists.txt
Outdated
Comment on lines
+4
to
+8
| # Grab all .cpp, but EXCLUDE the PCL file from the base set. | ||
| file(GLOB LLZKTransforms_SOURCES "*.cpp") | ||
|
|
||
|
|
||
| # Add the PCL lowering .cpp only when enabled. |
Member
There was a problem hiding this comment.
update the comments and remove the extra blank line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A basic pass to convert LLZK -> PCL. It should work on the majority of the SP1 benchmarks -- the only ops we don't handle are lookup constraints. I need to update PCL-MLIR to include those lookups.