Skip to content

Shankara/pcl include fix #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shankarapailoor merged 2 commits into from
Nov 21, 2025
Merged

Shankara/pcl include fix #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf5089
used the wrong cmake flag when guarding PCL imports
shankarapailoor Nov 21, 2025
531fa7a
fixing pcl includes
shankarapailoor Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/unreleased/shankara__pcl-include-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fixed:
- Used the wrong PCL guard variable in CMakeLists.txt.
2 changes: 1 addition & 1 deletion include/llzk/Transforms/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
include_directories(${MLIR_INCLUDE_DIRS} ${LLZK_INCLUDE_DIR})

set(_TBLGEN_PCL_FLAG "")
if(LLZK_WITH_PCL)
if(LLZK_WITH_PCL_BOOL)
set(_TBLGEN_PCL_FLAG "-DWITH_PCL")
endif()

Expand Down
2 changes: 1 addition & 1 deletion lib/Transforms/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ add_library(LLZK::LLZKTransforms ALIAS LLZKTransforms)
file(GLOB LLZKTransforms_SOURCES "*.cpp")

# Remove the PCL lowering .cpp only when disabled.
if(NOT LLZK_WITH_PCL)
if(NOT LLZK_WITH_PCL_BOOL)
list(REMOVE_ITEM LLZKTransforms_SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/LLZKPCLLoweringPass.cpp")
endif()

Expand Down
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set(LIT_ARGS "--xunit-xml-output report.xml")
# creating this guard and setting to 0-1
# because python doesn't like the ON/OFF stuff
set(LLZK_WITH_PCL_GUARD 0)
if(LLZK_WITH_PCL)
if(LLZK_WITH_PCL_BOOL)
set(LLZK_WITH_PCL_GUARD 1)
endif()

Expand Down
Loading