Merged
Conversation
iangneal
approved these changes
Nov 25, 2025
Contributor
iangneal
left a comment
iangneal
left a comment
There was a problem hiding this comment.
This is me, actually approving the PR.
raghav198
pushed a commit
that referenced
this pull request
Nov 26, 2025
also explicitly link LLZKDialect in the dialects that use it to fix linker error that surfaced as a result
raghav198
added a commit
that referenced
this pull request
Dec 9, 2025
* Registered new transformation pass * Concatenation pass works * deleted comments * Basic inlining complete * Fixed issue calling @Product * Refactoring, added root-struct option * Aligning subfunctions * Refactor to make struct inlining available on demand (#212) * For now, fail when we can't align some calls * [NFC] Refactor inline structs pass to prepare for handling more "remaining uses" (#218) * add debug output, clarify docs, fix typos * refactoring to prepare for handling more "remaining uses" * update debug output with new function names * Brought back LightweightSignalEquivalenceAnalysis * Added testcase * Shankara/pcl include fix (#221) * used the wrong cmake flag when guarding PCL imports * Added libAnalysis to CMake * Removed libAnalysis from CMake * Namespacing * Namespacing * Put analysis back * Link `LLZKAnalysis` in `LLZKTransforms` (#225) also explicitly link LLZKDialect in the dialects that use it to fix linker error that surfaced as a result * remove redundant "add_dependencies" from cmake (#226) * clang-format * Changelog * FORMAT * Addressing comments * update manual build instructions to build clang dependency * Addressing comments * Add missing headers to `llzk-tblgen` lib (#239) * Refactor to add calleeContainsWitnessGen() and getSingleResultTypeOfWitnessGen() instead of overloading ...Compute() * nit * revert --------- Co-authored-by: Raghav Malik <raghav@veridise.com> Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> Co-authored-by: shankarapailoor <shankarapailoor@gmail.com> Co-authored-by: Tim Hoffman <timothy.hoffman@veridise.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
libLLZKAnalysisas a dependency onlibLLZKTransforms. This caused a linking error in CI. The function mentioned is defined withinlibLLZKDialect. The uses that were it's reported undefined were inlibLLZKArrayDialectandlibLLZKStructDialect. Those libs did not explicitly link tolibLLZKDialectbut adding that resolved the errors.