Merged
Conversation
* Remove !Signal struct * Update include/llzk/Dialect/Struct/IR/Ops.td Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> * Remove dangling branch * Add `signal` attribute * Update lib/Analysis/IntervalAnalysis.cpp Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> * Swap `column` and `signal` in builder ordrer --------- Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
* Rename `struct.field` -> `struct.member` * Rename `readf` and `writef` to `readm` and `writem` * More pervasive `field` -> `member` renaming in variable names, etc: * Update changelog --------- Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
* Rename `struct.field` -> `struct.member` * Rename `readf` and `writef` to `readm` and `writem` * More pervasive `field` -> `member` renaming in variable names, etc: * Code review suggestion * Update changelog * Update lib/Dialect/Array/Transforms/ArrayToScalarPass.cpp Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com> * Add visibility check to MemberReadOp * Restrict member reads to public members for subcomponents * Fixup merge * Fix unresolved merge --------- Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
Contributor
Author
|
@tim-hoffman I realize we might want to wait on merging this, but I figure we should put it up now to keep it in mind. |
Member
Yes, I was just about to say that. I think it's easier to just hold off on this for now so we're not forced into supporting these renames in llzk-rs which would slow down the circom frontend. |
tim-hoffman
approved these changes
Feb 2, 2026
Contributor
Author
|
@tim-hoffman Now I pushed last, so you can approve, then I can merge. And with that, we have danced the Pull Request Tango™. |
tim-hoffman
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined merge of:
struct.fieldtostruct.memberrename (Renamestruct.field->struct.member#236)private member access restrictions ([LLZK-382] Disallow private member access #240)undefop intonondetop (refactorfelt.nondettollzk.nondetwith any type #251)Change(will delay to separate PR)veridise.lang=llzkon top module tollzk.lang=Xwhere X is a string that can be frontend source language