Skip to content

Fix IntervalAnalysis arith.constant issue with i1 values#284

Merged
iangneal merged 7 commits intomainfrom
iangneal/interval_analysis_const_bool_fix
Jan 26, 2026
Merged

Fix IntervalAnalysis arith.constant issue with i1 values#284
iangneal merged 7 commits intomainfrom
iangneal/interval_analysis_const_bool_fix

Conversation

@iangneal
Copy link
Contributor

  • arith.constant true and arith.constant false were being incorrectly converted to bitvectors in the SMT expressions, causing expression construction errors. Added a fix to check for arith.constant bitwidth before creating initial constant expressions
  • Fixed assertion error that occurred when running the interval analysis on a module with no structs. The analyses now just return no results as expected

@iangneal iangneal requested a review from a team January 23, 2026 21:59
Copy link
Member

@tim-hoffman tim-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
@iangneal iangneal requested a review from tim-hoffman January 26, 2026 16:17
@iangneal iangneal merged commit 2cbd4fe into main Jan 26, 2026
9 checks passed
@iangneal iangneal deleted the iangneal/interval_analysis_const_bool_fix branch January 26, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants