Skip to content

Remove felt.bitnot in favor of older felt.bit_not #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-hoffman merged 1 commit into from
Jan 26, 2026
Merged

Remove felt.bitnot in favor of older felt.bit_not #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/unreleased/iangneal__remove-redundant-op.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
removed:
- The `felt.bitnot` op was removed because `felt.bit_not` already existed
6 changes: 3 additions & 3 deletions include/llzk/Analysis/IntervalAnalysis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,9 @@ class IntervalDataFlowAnalysis
return llvm::isa<
felt::AddFeltOp, felt::SubFeltOp, felt::MulFeltOp, felt::DivFeltOp, felt::UnsignedModFeltOp,
felt::SignedModFeltOp, felt::SignedIntDivFeltOp, felt::UnsignedIntDivFeltOp,
felt::NegFeltOp, felt::InvFeltOp, felt::ComplementFeltOp, felt::AndFeltOp, felt::OrFeltOp,
felt::XorFeltOp, felt::NotFeltOp, felt::ShlFeltOp, felt::ShrFeltOp, boolean::CmpOp,
boolean::AndBoolOp, boolean::OrBoolOp, boolean::XorBoolOp, boolean::NotBoolOp>(op);
felt::NegFeltOp, felt::InvFeltOp, felt::AndFeltOp, felt::OrFeltOp, felt::XorFeltOp,
felt::NotFeltOp, felt::ShlFeltOp, felt::ShrFeltOp, boolean::CmpOp, boolean::AndBoolOp,
boolean::OrBoolOp, boolean::XorBoolOp, boolean::NotBoolOp>(op);
}

ExpressionValue
Expand Down
18 changes: 6 additions & 12 deletions include/llzk/Dialect/Felt/IR/Ops.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,6 @@ def LLZK_InvFeltOp : FeltDialectUnaryOp<"inv", LLZK_FeltType, [WitnessGen]> {
let description = [{}];
}

def LLZK_ComplementFeltOp
: FeltDialectUnaryOp<"bitnot", LLZK_FeltType, [WitnessGen]> {
let summary = "integer complement (bitwise-not) operator for field elements";
let description = [{
Treats the operand as an integer with a bitwidth equal to the bitwidth
of the prime field's modulus and compute the one's complement of the integer.
The result is converted back to a field element by applying the prime modulus.
}];
}

def LLZK_AndFeltOp
: FeltDialectBinaryOp<"bit_and", LLZK_FeltType, [WitnessGen, Commutative]> {
let summary = "bitwise AND operator for field elements";
Expand All @@ -206,8 +196,12 @@ def LLZK_XorFeltOp

def LLZK_NotFeltOp
: FeltDialectUnaryOp<"bit_not", LLZK_FeltType, [WitnessGen]> {
let summary = "bit flip operator for field elements";
let description = [{}];
let summary = "integer complement (bitwise-not) operator for field elements";
let description = [{
Treats the operand as an integer with a bitwidth equal to the bitwidth
of the prime field's modulus and compute the one's complement of the integer.
The result is converted back to a field element by applying the prime modulus.
}];
}

def LLZK_ShlFeltOp : FeltDialectBinaryOp<"shl", LLZK_FeltType, [WitnessGen]> {
Expand Down
11 changes: 0 additions & 11 deletions test/Dialect/Felt/felt_arith_pass.llzk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,17 +133,6 @@ function.def @f_inv(%a: !felt.type) -> !felt.type attributes {function.allow_wit
//CHECK-NEXT: }
// -----

function.def @f_bitnot(%a: !felt.type) -> !felt.type attributes {function.allow_witness} {
%c = felt.bitnot %a
function.return %c: !felt.type
}
//CHECK-LABEL: function.def @f_bitnot
//CHECK-SAME: (%[[A0:[0-9a-zA-Z_\.]+]]: !felt.type) -> !felt.type attributes {function.allow_witness} {
//CHECK-NEXT: %[[T1:[0-9a-zA-Z_\.]+]] = felt.bitnot %[[A0]]
//CHECK-NEXT: function.return %[[T1]] : !felt.type
//CHECK-NEXT: }
// -----

function.def @f_bit_and(%a: !felt.type, %b: !felt.type) -> !felt.type attributes {function.allow_witness} {
%c = felt.bit_and %a, %b
function.return %c: !felt.type
Expand Down