Specify main via attribute instead of reserved name#295
Merged
tim-hoffman merged 7 commits intomainfrom Jan 29, 2026
Merged
Conversation
Contributor
|
Should resolve #294 yes? |
Member
Author
yes |
iangneal
requested changes
Jan 29, 2026
Contributor
iangneal
left a comment
iangneal
left a comment
There was a problem hiding this comment.
Overall LGTM, but can we also add a test case for using a struct with parameters as the main component?
Member
Author
Good point. |
iangneal
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the means of specifying the main entry point struct from a reserved name "Main" to an attribute on the top module. Also changes the parameter type restriction on the main struct from
!struct.type<@Signal>to!felt.type(and comments that Signal is deprecated, soon to be removed).Consequently, resolves #294