Merged
Conversation
Resolves #135
Member
|
@iangneal the requirement is bigger than what's covered here. Will that be added to this PR as well? |
Member
And actually a bit different. |
Contributor
Author
|
@tim-hoffman I still need to update the CAPI with the new functionality but I'll wait for a first review pass so I don't have to redo the CAPI multiple times based on code review feedback. |
tim-hoffman
reviewed
Feb 6, 2026
Member
tim-hoffman
left a comment
tim-hoffman
left a comment
There was a problem hiding this comment.
Initial comments. I have a few more files to check.
tim-hoffman
approved these changes
Feb 6, 2026
Member
tim-hoffman
left a comment
tim-hoffman
left a comment
There was a problem hiding this comment.
LGTM (I pushed one more commit and have one nit here)
Co-authored-by: Timothy Hoffman <4001421+tim-hoffman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #135.