Skip to content

remove remaining uses of "Signal"#302

Merged
iangneal merged 7 commits intomainfrom
th/cleanup_signal_comments
Feb 8, 2026
Merged

remove remaining uses of "Signal"#302
iangneal merged 7 commits intomainfrom
th/cleanup_signal_comments

Conversation

@tim-hoffman
Copy link
Member

@tim-hoffman tim-hoffman commented Feb 5, 2026

  • Updates some documentation that still mentions the removed Signal struct.
  • Fix regression that had removed the restriction that cast.toindex cannot be done on signals. The restriction is loosened so that this cast can be done only if allow_non_native_field_ops attribute is present on the function.

@tim-hoffman tim-hoffman requested a review from a team February 5, 2026 21:16
@tim-hoffman tim-hoffman marked this pull request as ready for review February 5, 2026 22:14
tim-hoffman and others added 2 commits February 5, 2026 16:55
Co-authored-by: Raghav Malik <malikraghav9@gmail.com>
@tim-hoffman tim-hoffman requested a review from raghav198 February 5, 2026 22:58
Copy link
Contributor

@raghav198 raghav198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-hoffman tim-hoffman requested a review from iangneal February 7, 2026 00:28
@iangneal iangneal merged commit 67030b1 into main Feb 8, 2026
9 checks passed
@iangneal iangneal deleted the th/cleanup_signal_comments branch February 8, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants