feat(build): uniform ini parsing (go-gitea#7429)

- Use the existing ini parser for the `lint-locale` and `lint-locale-usage` tooling.
- This discovered that the previous ini parser was not correctly parsing certain types of string, specifically those with `;` as it's seen as a comment. It now properly 'unescapes' that and is not seen as a comment break.
- Discovered-by: @fogti

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7429
Reviewed-by: Earl Warren <[email protected]>
Co-authored-by: Gusted <[email protected]>
Co-committed-by: Gusted <[email protected]>

Author: Gusted

build/lint-locale/lint-locale_test.go

@@ -60,7 +60,7 @@ func TestLocalizationPolicy(t *testing.T) {
 	t.Run("Escaped HTML characters", func(t *testing.T) {
 		assert.Empty(t, checkLocaleContent([]byte("activity.git_stats_push_to_branch = `إلى %s و\"`")))
 
-		assert.Equal(t, []string{"key: و\x1b[31m&nbsp\x1b[0m\x1b[32m\u00a0\x1b[0m"}, checkLocaleContent([]byte(`key = و `)))
+		assert.Equal(t, []string{"key: و\x1b[31m \x1b[0m\x1b[32m\u00a0\x1b[0m"}, checkLocaleContent([]byte(`key = و `)))
 	})
 }
 

modules/translation/localeiter/utils.go

@@ -10,17 +10,12 @@ import (
 	"encoding/json" //nolint:depguard
 	"fmt"
 
-	"gopkg.in/ini.v1" //nolint:depguard
+	"forgejo.org/modules/setting"
 )
 
 func IterateMessagesContent(localeContent []byte, onMsgid func(string, string) error) error {
-	// Same configuration as Forgejo uses.
-	cfg := ini.Empty(ini.LoadOptions{
-		IgnoreContinuation: true,
-	})
-	cfg.NameMapper = ini.SnackCase
-
-	if err := cfg.Append(localeContent); err != nil {
+	cfg, err := setting.NewConfigProviderForLocale(localeContent)
+	if err != nil {
 		return err
 	}