fix: technical rankフィルタが理論値を無条件で弾く問題の修正#1020
Merged
slime-hatena merged 3 commits intoproject-primera:developfrom Mar 14, 2026
Merged
fix: technical rankフィルタが理論値を無条件で弾く問題の修正#1020slime-hatena merged 3 commits intoproject-primera:developfrom
slime-hatena merged 3 commits intoproject-primera:developfrom
Conversation
Member
|
だいぶ長い期間放置してしまいすみません。問題なさそうなのでマージします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
実装概要
のような形でフィルタを修正。
OngekiUtilityにgetLampForRatingを追加し、既存の同等処理を当該関数を使用して行うように変更
結果
fixes: #1019
備考
2に関して問題あれば e0663b1 と 075f77f をrevertしていただけるとありがたいです。